[PATCH] depmod: always initialize "deps" in mod_get_all_sorted_dependencies()

[Cristian Rodríguez]

Fixed Coverity CID #48861
---
tools/depmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/depmod.c b/tools/depmod.c
index e90ff83..bcefa09 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -1798,14 +1798,14 @@ static int mod_fill_all_unique_dependencies(const struct mod *mod, const struct

static const struct mod **mod_get_all_sorted_dependencies(const struct mod *mod, size_t *n_deps)
{
- const struct mod **deps;
+ const struct mod **deps = NULL;
size_t last = 0;

*n_deps = mod_count_all_dependencies(mod);
if (*n_deps == 0)
return NULL;

- deps = malloc(sizeof(struct mod *) * (*n_deps));
+ deps = calloc(1, sizeof(struct mod *) * (*n_deps));
if (deps == NULL)
return NULL;

[Lucas De Marchi]

On Sun, Sep 21, 2014 at 9:20 PM, Cristian Rodr=C3=ADguez

Post by Cristian Rodríguez
Fixed Coverity CID #48861
---

Is there anything being really fixed here?

Post by Cristian Rodríguez
tools/depmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/depmod.c b/tools/depmod.c
index e90ff83..bcefa09 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -1798,14 +1798,14 @@ static int mod_fill_all_unique_dependencies(c=

onst struct mod *mod, const struct

Post by Cristian Rodríguez
static const struct mod **mod_get_all_sorted_dependencies(const stru=

ct mod *mod, size_t *n_deps)

Post by Cristian Rodríguez
{
- const struct mod **deps;
+ const struct mod **deps =3D NULL;

you are assigning deps to the return of malloc below.

Post by Cristian Rodríguez
size_t last =3D 0;
*n_deps =3D mod_count_all_dependencies(mod);
if (*n_deps =3D=3D 0)
return NULL;
- deps =3D malloc(sizeof(struct mod *) * (*n_deps));
+ deps =3D calloc(1, sizeof(struct mod *) * (*n_deps));

and we are supposed to fill n_deps in
mod_fill_all_unique_dependencies() so there's no point in initializing
them to 0 here.

--=20

Lucas De Marchi