Lucas De Marchi
2013-08-14 01:08:52 UTC
On Tue, Aug 13, 2013 at 10:00 PM, Lucas De Marchi
parameter correctly from kernel command line if it doesn't have a
value. And I agree this not something that changed but rather a bug in
kmod waiting to be fixed.
And it's fixed now with a proper test added.
thanks
Lucas De Marchi
On Tue, 13 Aug 2013 20:34:58 -0300
that uses "module_param()" with bool type (a quick git grep shows 570
users), already do not require a value.
Randomly looking at one... drivers/input/mouse/synaptics_i2c.c, you can
insmod synaptics_i2c.ko no_filter
no need to add a "=1" to that.
But anything else will still require a value. I just want to allow
other parameters that act like a boolean to not require one.
true... but currently "modprobe synaptics_i2c" doesn't get theso in kcmdline we would have modulename.param instead of modulename.param=1?
I guess we need to update kmod then, because currently we ignore and
treat this case as a wrong token. From a quick look, allowing it in
kmod would be as simple as removing a condition check.
Lucas De Marchi
Note, both will still work. And it didn't change much. Today, anythingI guess we need to update kmod then, because currently we ignore and
treat this case as a wrong token. From a quick look, allowing it in
kmod would be as simple as removing a condition check.
Lucas De Marchi
that uses "module_param()" with bool type (a quick git grep shows 570
users), already do not require a value.
Randomly looking at one... drivers/input/mouse/synaptics_i2c.c, you can
insmod synaptics_i2c.ko no_filter
no need to add a "=1" to that.
But anything else will still require a value. I just want to allow
other parameters that act like a boolean to not require one.
parameter correctly from kernel command line if it doesn't have a
value. And I agree this not something that changed but rather a bug in
kmod waiting to be fixed.
thanks
Lucas De Marchi